-
Notifications
You must be signed in to change notification settings - Fork 94
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(analytics): add test and fix youtube
Adds unit testing and fixes analytics for youtube.
- Loading branch information
Showing
5 changed files
with
120 additions
and
77 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,81 +1,112 @@ | ||
| import React from 'react'; | ||
| import renderer from 'react-test-renderer'; | ||
| import { mount } from 'enzyme'; | ||
|
|
||
| import FooterLogo from '../../../edx-footer.png'; | ||
| import SiteFooter from '../../index'; | ||
| import SiteFooter, { EVENT_NAMES } from './index'; | ||
|
|
||
| const completeSiteFooterComponent = mockHandleAllTrackEvents => | ||
| (<SiteFooter | ||
| siteName="example" | ||
| siteLogo={FooterLogo} | ||
| marketingSiteBaseUrl="https://www.example.com" | ||
| supportUrl="https://www.example.com/support" | ||
| contactUrl="https://www.example.com/contact" | ||
| openSourceUrl="https://www.example.com/open" | ||
| termsOfServiceUrl="https://www.example.com/terms-of-service" | ||
| privacyPolicyUrl="https://www.example.com/privacy-policy" | ||
| facebookUrl="https://www.facebook.com" | ||
| twitterUrl="https://www.twitter.com" | ||
| youTubeUrl="https://www.youtube.com" | ||
| linkedInUrl="https://www.linkedin.com" | ||
| googlePlusUrl="https://plus.google.com" | ||
| redditUrl="https://reddit.com" | ||
| appleAppStoreUrl="https://store.apple.com" | ||
| googlePlayUrl="https://play.google.com" | ||
| handleAllTrackEvents={mockHandleAllTrackEvents} | ||
| />); | ||
|
|
||
| describe('<SiteFooter />', () => { | ||
| it('renders correctly', () => { | ||
| const tree = renderer | ||
| .create(<SiteFooter | ||
| siteName="example" | ||
| siteLogo={FooterLogo} | ||
| marketingSiteBaseUrl="https://www.example.com" | ||
| supportUrl="https://www.example.com/support" | ||
| contactUrl="https://www.example.com/contact" | ||
| openSourceUrl="https://www.example.com/open" | ||
| termsOfServiceUrl="https://www.example.com/terms-of-service" | ||
| privacyPolicyUrl="https://www.example.com/privacy-policy" | ||
| facebookUrl="https://www.facebook.com" | ||
| twitterUrl="https://www.twitter.com" | ||
| youTubeUrl="https://www.youtube.com" | ||
| linkedInUrl="https://www.linkedin.com" | ||
| googlePlusUrl="https://plus.google.com" | ||
| redditUrl="https://reddit.com" | ||
| appleAppStoreUrl="https://store.apple.com" | ||
| googlePlayUrl="https://play.google.com" | ||
| />) | ||
| .toJSON(); | ||
| expect(tree).toMatchSnapshot(); | ||
| }); | ||
| describe('renders correctly', () => { | ||
| it('renders with social and mobile links', () => { | ||
| const mockHandleAllTrackEvents = jest.fn(); | ||
| const tree = renderer | ||
| .create(completeSiteFooterComponent(mockHandleAllTrackEvents)) | ||
| .toJSON(); | ||
| expect(tree).toMatchSnapshot(); | ||
| }); | ||
|
|
||
| it('does not render social links', () => { | ||
| const tree = renderer | ||
| .create(<SiteFooter | ||
| siteName="example" | ||
| siteLogo={FooterLogo} | ||
| marketingSiteBaseUrl="https://www.example.com" | ||
| supportUrl="https://www.example.com/support" | ||
| contactUrl="https://www.example.com/contact" | ||
| openSourceUrl="https://www.example.com/open" | ||
| termsOfServiceUrl="https://www.example.com/terms-of-service" | ||
| privacyPolicyUrl="https://www.example.com/privacy-policy" | ||
| facebookUrl="https://www.facebook.com" | ||
| twitterUrl="https://www.twitter.com" | ||
| youTubeUrl="https://www.youtube.com" | ||
| linkedInUrl="https://www.linkedin.com" | ||
| googlePlusUrl="https://plus.google.com" | ||
| redditUrl="https://reddit.com" | ||
| appleAppStoreUrl="https://store.apple.com" | ||
| googlePlayUrl="https://play.google.com" | ||
| showSocialLinks={false} | ||
| />) | ||
| .toJSON(); | ||
| expect(tree).toMatchSnapshot(); | ||
| it('does not render social links', () => { | ||
| const tree = renderer | ||
| .create(<SiteFooter | ||
| siteName="example" | ||
| siteLogo={FooterLogo} | ||
| marketingSiteBaseUrl="https://www.example.com" | ||
| supportUrl="https://www.example.com/support" | ||
| contactUrl="https://www.example.com/contact" | ||
| openSourceUrl="https://www.example.com/open" | ||
| termsOfServiceUrl="https://www.example.com/terms-of-service" | ||
| privacyPolicyUrl="https://www.example.com/privacy-policy" | ||
| facebookUrl="https://www.facebook.com" | ||
| twitterUrl="https://www.twitter.com" | ||
| youTubeUrl="https://www.youtube.com" | ||
| linkedInUrl="https://www.linkedin.com" | ||
| googlePlusUrl="https://plus.google.com" | ||
| redditUrl="https://reddit.com" | ||
| appleAppStoreUrl="https://store.apple.com" | ||
| googlePlayUrl="https://play.google.com" | ||
| handleAllTrackEvents={jest.fn()} | ||
| showSocialLinks={false} | ||
| />) | ||
| .toJSON(); | ||
| expect(tree).toMatchSnapshot(); | ||
| }); | ||
|
|
||
| it('does not render mobile links', () => { | ||
| const tree = renderer | ||
| .create(<SiteFooter | ||
| siteName="example" | ||
| siteLogo={FooterLogo} | ||
| marketingSiteBaseUrl="https://www.example.com" | ||
| supportUrl="https://www.example.com/support" | ||
| contactUrl="https://www.example.com/contact" | ||
| openSourceUrl="https://www.example.com/open" | ||
| termsOfServiceUrl="https://www.example.com/terms-of-service" | ||
| privacyPolicyUrl="https://www.example.com/privacy-policy" | ||
| facebookUrl="https://www.facebook.com" | ||
| twitterUrl="https://www.twitter.com" | ||
| youTubeUrl="https://www.youtube.com" | ||
| linkedInUrl="https://www.linkedin.com" | ||
| googlePlusUrl="https://plus.google.com" | ||
| redditUrl="https://reddit.com" | ||
| appleAppStoreUrl="https://store.apple.com" | ||
| googlePlayUrl="https://play.google.com" | ||
| handleAllTrackEvents={jest.fn()} | ||
| showMobileLinks={false} | ||
| />) | ||
| .toJSON(); | ||
| expect(tree).toMatchSnapshot(); | ||
| }); | ||
| }); | ||
|
|
||
| it('does not render mobile links', () => { | ||
| const tree = renderer | ||
| .create(<SiteFooter | ||
| siteName="example" | ||
| siteLogo={FooterLogo} | ||
| marketingSiteBaseUrl="https://www.example.com" | ||
| supportUrl="https://www.example.com/support" | ||
| contactUrl="https://www.example.com/contact" | ||
| openSourceUrl="https://www.example.com/open" | ||
| termsOfServiceUrl="https://www.example.com/terms-of-service" | ||
| privacyPolicyUrl="https://www.example.com/privacy-policy" | ||
| facebookUrl="https://www.facebook.com" | ||
| twitterUrl="https://www.twitter.com" | ||
| youTubeUrl="https://www.youtube.com" | ||
| linkedInUrl="https://www.linkedin.com" | ||
| googlePlusUrl="https://plus.google.com" | ||
| redditUrl="https://reddit.com" | ||
| appleAppStoreUrl="https://store.apple.com" | ||
| googlePlayUrl="https://play.google.com" | ||
| showMobileLinks={false} | ||
| />) | ||
| .toJSON(); | ||
| expect(tree).toMatchSnapshot(); | ||
| describe('handles analytics', () => { | ||
| it('calls handleAllTrackEvents prop when external links clicked', () => { | ||
| const mockHandleAllTrackEvents = jest.fn(); | ||
| const footer = mount((completeSiteFooterComponent(mockHandleAllTrackEvents))); | ||
| const externalLinks = footer.find("a[target='_blank']"); | ||
|
|
||
| expect(externalLinks).toHaveLength(8); | ||
| externalLinks.forEach((externalLink) => { | ||
| const callIndex = mockHandleAllTrackEvents.mock.calls.length; | ||
| externalLink.simulate('click'); | ||
| expect(mockHandleAllTrackEvents.mock.calls[callIndex]).toEqual([ | ||
| EVENT_NAMES.FOOTER_LINK, | ||
| { | ||
| category: 'outbound_link', | ||
| label: externalLink.prop('href'), | ||
| }, | ||
| ]); | ||
| }); | ||
| }); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters