Skip to content

Commit

Permalink
refactor: more updates
Browse files Browse the repository at this point in the history
  • Loading branch information
@asadali145
asadali145 committed Jan 25, 2024
1 parent c4ad876 commit 7e3966f
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 21 deletions.
1 change: 0 additions & 1 deletion .env.development
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,5 @@ CONTACT_URL=
SUPPORT_CENTER_URL=
SUPPORT_CENTER_TEXT=
TRADEMARK_TEXT=
SITE_URL=
LOGO_ALT_TEXT=
SHOW_LOGO=
1 change: 1 addition & 0 deletions README.rst
View file
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ Reporting Security Issues
=========================

Please do not report security issues in public. Please email security@openedx.org.

.. |Build Status| image:: https://api.travis-ci.com/edx/frontend-component-footer.svg?branch=master
:target: https://travis-ci.com/edx/frontend-component-footer
.. |Codecov| image:: https://img.shields.io/codecov/c/github/edx/frontend-component-footer
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "@edx/frontend-component-footer-mitol",
"name": "@edx/frontend-component-footer",
"version": "1.0.0-semantically-released",
"description": "Footer component for use when building Open edX frontend applications",
"main": "dist/index.js",
Expand Down
2 changes: 1 addition & 1 deletion src/components/Footer.jsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class SiteFooter extends React.Component {
{this.renderLinkIfExists(process.env.TERMS_OF_SERVICE_URL, 'Terms of Service')}
{this.renderLinkIfExists(process.env.PRIVACY_POLICY_URL, 'Privacy Policy')}
{this.renderLinkIfExists(process.env.HONOR_CODE_URL, 'Honor Code')}
{this.renderLinkIfExists(process.env.Contact, 'Contact')}
{this.renderLinkIfExists(process.env.CONTACT_URL, 'Contact Us')}
{this.renderLinkIfExists(process.env.ACCESSIBILITY_URL, 'Accessibility')}
{this.renderLinkIfExists(process.env.SUPPORT_CENTER_URL, process.env.SUPPORT_CENTER_TEXT || 'FAQ & Help')}
</ul>
Expand Down
24 changes: 12 additions & 12 deletions src/components/__snapshots__/Footer.test.jsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ exports[`<Footer /> renders correctly renders with a language selector 1`] = `
</li>
<li>
<a
href="http://localhost:18000/tos_and_honor"
href="http://localhost:18000/terms-of-service"
>
Terms of Service
</a>
Expand All @@ -58,21 +58,21 @@ exports[`<Footer /> renders correctly renders with a language selector 1`] = `
</li>
<li>
<a
href="http://localhost:18000/tos_and_honor"
href="http://localhost:18000/honor"
>
Honor Code
</a>
</li>
<li>
<a
href="https://accessibility.mit.edu/"
href="https://www.edx.org/accessibility"
>
Accessibility
</a>
</li>
<li>
<a
href="http://localhost:18000/about"
href="http://localhost:18000/contact"
>
SUPPORT CENTER
</a>
Expand Down Expand Up @@ -170,7 +170,7 @@ exports[`<Footer /> renders correctly renders without a language selector 1`] =
</li>
<li>
<a
href="http://localhost:18000/tos_and_honor"
href="http://localhost:18000/terms-of-service"
>
Terms of Service
</a>
Expand All @@ -184,21 +184,21 @@ exports[`<Footer /> renders correctly renders without a language selector 1`] =
</li>
<li>
<a
href="http://localhost:18000/tos_and_honor"
href="http://localhost:18000/honor"
>
Honor Code
</a>
</li>
<li>
<a
href="https://accessibility.mit.edu/"
href="https://www.edx.org/accessibility"
>
Accessibility
</a>
</li>
<li>
<a
href="http://localhost:18000/about"
href="http://localhost:18000/contact"
>
SUPPORT CENTER
</a>
Expand Down Expand Up @@ -257,7 +257,7 @@ exports[`<Footer /> renders correctly renders without a language selector in es
</li>
<li>
<a
href="http://localhost:18000/tos_and_honor"
href="http://localhost:18000/terms-of-service"
>
Terms of Service
</a>
Expand All @@ -271,21 +271,21 @@ exports[`<Footer /> renders correctly renders without a language selector in es
</li>
<li>
<a
href="http://localhost:18000/tos_and_honor"
href="http://localhost:18000/honor"
>
Honor Code
</a>
</li>
<li>
<a
href="https://accessibility.mit.edu/"
href="https://www.edx.org/accessibility"
>
Accessibility
</a>
</li>
<li>
<a
href="http://localhost:18000/about"
href="http://localhost:18000/contact"
>
SUPPORT CENTER
</a>
Expand Down
11 changes: 5 additions & 6 deletions src/setupTest.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,13 @@ process.env.LOGO_WHITE_URL = 'https://edx-cdn.org/v3/default/logo-white.svg';
process.env.FAVICON_URL = 'https://edx-cdn.org/v3/default/favicon.ico';
process.env.ABOUT_US_URL = 'http://localhost:18000/about';
process.env.PRIVACY_POLICY_URL = 'http://localhost:18000/privacy';
process.env.HONOR_CODE_URL = 'http://localhost:18000/tos_and_honor';
process.env.TERMS_OF_SERVICE_URL = 'http://localhost:18000/tos_and_honor';
process.env.CONTACT_URL = 'http://localhost:18000/about';
process.env.SUPPORT_CENTER_URL = 'http://localhost:18000/about';
process.env.HONOR_CODE_URL = 'http://localhost:18000/honor';
process.env.TERMS_OF_SERVICE_URL = 'http://localhost:18000/terms-of-service';
process.env.CONTACT_URL = 'http://localhost:18000/contact';
process.env.SUPPORT_CENTER_URL = 'http://localhost:18000/contact';
process.env.SUPPORT_CENTER_TEXT = 'SUPPORT CENTER';
process.env.TRADEMARK_TEXT = 'Trade Mark text';
process.env.SITE_URL = 'http://localhost:18000/';
process.env.LOGO_ALT_TEXT = 'alt text';
process.env.SHOW_LOGO = true;
process.env.SUPPORT_EMAIL = 'webmaster@email.com';
process.env.ACCESSIBILITY_URL = 'https://accessibility.mit.edu/';
process.env.ACCESSIBILITY_URL = 'https://www.edx.org/accessibility';

0 comments on commit 7e3966f

Please sign in to comment.