Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: silence sass compiler warnings about Dart Sass deprecations #425

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

adamstankiewicz
Copy link
Member

@adamstankiewicz adamstankiewicz commented Jul 19, 2023

https://sass-lang.com/documentation/js-api/interfaces/options/#quietDeps

If this option is set to true, Sass won’t print warnings that are caused by dependencies. A “dependency” is defined as any file that’s loaded through loadPaths or importers. Stylesheets that are imported relative to the entrypoint are not considered dependencies.

twbs/bootstrap#34051

Example deprecation warnings seen throughout MFEs (common issue):

WARNING in ./src/index.scss (./node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[1].use[1]!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[1].use[2]!./node_modules/resolve-url-loader/index.js!./node_modules/sass-loader/dist/cjs.js??ruleSet[1].rules[1].use[4]!./src/index.scss)
Module Warning (from ./node_modules/sass-loader/dist/cjs.js):
Deprecation Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(2em, 14) or calc(2em / 14)

More info and automated migrator: https://sass-lang.com/d/slash-div

node_modules/font-awesome/scss/_list.scss 14:9         @import
node_modules/font-awesome/scss/font-awesome.scss 12:9  @import
src/index.scss 9:9                                     root stylesheet

 @ ./src/index.scss 8:6-311 22:17-24 26:7-21 52:25-39 53:36-47 53:50-64 57:6-67:7 58:54-65 58:68-82 64:42-53 64:56-70 66:21-28 77:0-281 77:0-281 78:22-29 78:33-47 78:50-64 55:4-68:5
 @ ./src/index.jsx 14:0-22

image

@adamstankiewicz adamstankiewicz changed the title fix: silence sass compiler warnings fix: silence sass compiler warnings about Dart Sass deprecations Jul 19, 2023
Copy link
Member

@brobro10000 brobro10000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inspiring!

@adamstankiewicz adamstankiewicz merged commit 0f8f544 into master Jul 19, 2023
@adamstankiewicz adamstankiewicz deleted the ags/dart-warnings branch July 19, 2023 16:52
@edx-semantic-release
Copy link

🎉 This PR is included in version 12.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants