Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove messagesDir for babel-react-intl 8 #286

Closed
wants to merge 1 commit into from

Conversation

leangseu-edx
Copy link
Contributor

@leangseu-edx leangseu-edx commented Dec 21, 2022

The support for messageDir has been drop. formatjs/formatjs@47ca556

There should be a future plan use babel-plugin-formatjs instead because babel-react-intl has already been archived and moved.

@adamstankiewicz
Copy link
Member

adamstankiewicz commented Dec 21, 2022

@leangseu-edx What is the consequence of removing messagesDir? How will our i18n process still function without it, if this is the only change? Is there a way we can ensure we stay on a version of babel-plugin-react-intl that supports messagesDir for now?

For example, I believe the path given to messagesDir is referenced in frontend-app-learning's Makefile around defining the i18n-related Make targets (source).

There should be a future plan use babel-plugin-formatjs instead because babel-react-intl has already been archived and moved.

@leangseu-edx The migration from babel-react-intl to babel-plugin-formatjs is something we prioritized with FED-BOM and looks to still be in progress (issue and PR).

@adamstankiewicz adamstankiewicz deleted the lk/fix-babel-react-intl branch December 21, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants