Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrated off babel-plugin-react-intl #258

Merged
merged 8 commits into from
Jan 20, 2023
Merged

refactor: migrated off babel-plugin-react-intl #258

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
189abcd
refactor: migrated off babel-plugin-react-intl
BilalQamar95 Aug 24, 2022
e821b3d
refactor: removed messagesDir
BilalQamar95 Aug 24, 2022
9060de3
Merge branch 'master' of https://github.com/openedx/frontend-build in…
BilalQamar95 Nov 9, 2022
bb7a8f1
refactor: updated package-lock
BilalQamar95 Nov 9, 2022
190dad2
Merge branch 'master' of https://github.com/openedx/frontend-build in…
BilalQamar95 Dec 1, 2022
eb79f4b
refactor: removed deprecated moduleSourceName
BilalQamar95 Dec 1, 2022
72ff20a
Merge branch 'master' of github.com:openedx/frontend-build into bilal…
abdullahwaheed Dec 22, 2022
716370f
refactor: removed moduleSourceName as suggested because it was redundant
abdullahwaheed Dec 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions config/babel-preserve-modules.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,8 @@ module.exports = {
i18n: {
plugins: [
[
'react-intl',
'formatjs',
{
messagesDir: './temp/babel-plugin-react-intl',
moduleSourceName: '@edx/frontend-platform/i18n',
abdullahwaheed marked this conversation as resolved.
Show resolved Hide resolved
},
],
Expand Down
3 changes: 1 addition & 2 deletions config/babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,8 @@ module.exports = {
i18n: {
plugins: [
[
'react-intl',
'formatjs',
{
messagesDir: './temp/babel-plugin-react-intl',
moduleSourceName: '@edx/frontend-platform/i18n',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like moduleSourceName was removed in v9.0.0. Can you confirm we really don't need to do anything else in addition to just removing the line?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this one seems extra, i think we can safely remove it

},
],
Expand Down
Loading