feat: upgraded to node v18, added .nvmrc and updated workflows #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mashal-m
force-pushed
the
mashal-m/node-18-upgrade
branch
from
06c8b14
to
eb5c392
Compare
Mashal-m
force-pushed
the
mashal-m/node-18-upgrade
branch
from
7bb7ae4
to
d65b329
Compare
DawoudSheraz
approved these changes
Apr 10, 2023
added 8 commits
May 11, 2023 18:09
Mashal-m
force-pushed
the
mashal-m/node-18-upgrade
branch
from
98f6c91
to
cddf0d9
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #837 +/- ##
=======================================
Coverage 66.05% 66.05%
=======================================
Files 127 127
Lines 3149 3149
Branches 911 911
=======================================
Hits 2080 2080
Misses 1021 1021
Partials 48 48 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Upgrade Node JS from 16 to 18
edx-internal PR
https://github.com/edx/edx-internal/pull/8322
Both these PRs need to be merged together.