feat: validate submission response required fields #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #241 +/- ##
==========================================
+ Coverage 89.19% 89.29% +0.10%
==========================================
Files 142 143 +1
Lines 2175 2205 +30
Branches 468 476 +8
==========================================
+ Hits 1940 1969 +29
Misses 222 222
- Partials 13 14 +1 ☔ View full report in Codecov by Sentry. |
hajorg
requested review from
a team,
BrandonHBodine,
jansenk,
nsprenkle,
KristinAoki and
Rodra
and removed request for
a team
KristinAoki
reviewed
Sep 27, 2024
src/components/FileUpload/index.jsx
Outdated
| /> | ||
| <Form.Group isInValid> | ||
| <Dropzone | ||
| multiple |
There was a problem hiding this comment.
I know that you didn't change this, but to my knowledge the paragon version of dropzone does not support multiple files. I would double check this functionality and remove the attribute if multiple files are not supported.
There was a problem hiding this comment.
Correct. I attempted to upload two files at a time but came across this error Only one upload permitted.
KristinAoki
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Text and file upload requirement not being applied when submitting an ORA and it's letting learners submit without meeting the response requirement. This PR validates the required fields