Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] feat: added start:with-theme script #138

Conversation

PKulkoRaccoonGang
Copy link
Contributor

Description

Added application start script with the ability to install the required theme (default @openedx/brand-openedx@latest). After interrupting a running process, the topic is automatically removed from the node_modules directory.

Related to: openedx/paragon#2831

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Dec 14, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f62996d) 82.79% compared to head (79c6470) 82.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   82.79%   82.79%           
=======================================
  Files         146      146           
  Lines        1697     1697           
  Branches      407      407           
=======================================
  Hits         1405     1405           
  Misses        250      250           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viktorrusakov viktorrusakov force-pushed the Peter_Kulko/start-with-theme-script branch from 268dba0 to 79c6470 Compare December 15, 2023 08:15
@viktorrusakov viktorrusakov merged commit 92e9ead into openedx:master Dec 15, 2023
6 checks passed
@leangseu-edx
Copy link
Contributor

This merge has caused the prod to lost all of the css. I am not sure what the cause however, I would halt in moving forward with this change. Mainly because this project is still in the first stage of rolling out.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants