-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use atlas
in make pull_translations
#179
Conversation
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
"@edx/frontend-component-footer": "^11.7.0", | ||
"@edx/frontend-component-header": "^3.7.0", | ||
"@edx/frontend-platform": "^4.1.0", | ||
"@edx/paragon": "^20.30.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading to the to near-latest packages since further versions fails. Copied from #176.
Upgrading to more recent versions creates conflicts, which can be tackled later in my opinion.
import messages from './i18n'; | ||
|
||
import App from './App'; | ||
|
||
subscribe(APP_READY, () => { | ||
ReactDOM.render( | ||
<IntlProvider locale="en"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now included within AppProvider.
4e11e57
to
0de98c0
Compare
Changes ------- - Bump frontend-platform to bring `intl-imports.js` script - Move all i18n imports into `src/i18n/index.js` so `intl-imports.js` can override it with latest translations - Add `atlas` into `make pull_translations` when `OPENEDX_ATLAS_PULL` environment variable is set. - package.json and package-lock.json are copied from openedx#176 - updated snapshots and updated tests in sync with `frontend-platform` - require package-lock.json version 3: same as openedx#176 Refs: [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) implementing Translation Infrastructure OEP-58.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #179 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 111 111
Lines 1080 1080
Branches 158 158
=========================================
Hits 1080 1080
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@mphilbrick211 this should be good to go! The spreadsheet still says "Need edX answer," anyone specific I should tag on this? |
Hi @mattcarter and @openedx/content-aurora! Would someone be able to review/merge this for us? Thanks! |
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Changes
intl-imports.js
scriptsrc/i18n/index.js
sointl-imports.js
canoverride it with latest translations
atlas
intomake pull_translations
whenOPENEDX_ATLAS_PULL
environment variable is set.
Testing
Screenshot
References
This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.
Join the conversation on Open edX Slack #translations-project-fc-0012.
Check the links above for full information about the overall project.
Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:
.json
,.po
or.mo
files will be committed into the repos.make extract_translations
in all repositoriesBreaking Changes
One of the primary goals of the project is to avoid breaking changes. If you noticed any suspicious code, please raise your concern. But before that, please know the strategy we're following to avoid breaking changes:
For Micro-frontends:
src/i18n/index.js
atlas
integration inmake pull_translations
but only ifOPENEDX_ATLAS_PULL
is setintl-imports.js
to generate up to date import files