Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ENT-8192 Academy tags connected to Algolia search #922

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

irfanuddinahmad
Copy link
Contributor

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 108 lines in your changes are missing coverage. Please review.

Comparison is base (d36b78a) 84.87% compared to head (79d6e38) 84.60%.
Report is 127 commits behind head on master.

Files Patch % Lines
src/components/academies/CourseCard.jsx 71.11% 13 Missing ⚠️
src/components/my-career/data/hooks.jsx 0.00% 12 Missing ⚠️
src/components/my-career/VisualizeCareer.jsx 74.07% 6 Missing and 1 partial ⚠️
src/components/my-career/data/service.js 56.25% 7 Missing ⚠️
src/components/course/data/utils.jsx 95.89% 6 Missing ⚠️
src/components/my-career/AddJobRole.jsx 71.42% 5 Missing and 1 partial ⚠️
src/components/app/App.jsx 0.00% 5 Missing ⚠️
src/components/app/EnterpriseAppPageRoutes.jsx 0.00% 5 Missing ⚠️
...components/enterprise-user-subsidy/data/service.js 0.00% 5 Missing ⚠️
src/components/academies/data/hooks.js 86.20% 4 Missing ⚠️
... and 22 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #922      +/-   ##
==========================================
- Coverage   84.87%   84.60%   -0.27%     
==========================================
  Files         320      342      +22     
  Lines        6399     7302     +903     
  Branches     1552     1792     +240     
==========================================
+ Hits         5431     6178     +747     
- Misses        941     1094     +153     
- Partials       27       30       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@muhammad-ammar muhammad-ammar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once build is green

One suggestion: We need to create a ticket to refactor CourseCard.jsx. Now this component have tags and soon we will add pathways so we need a better name.

@irfanuddinahmad irfanuddinahmad changed the title feat: ENT-8192 Academy tags chips connected to Algolia search feat: ENT-8192 Academy tags connected to Algolia search Jan 19, 2024
@irfanuddinahmad irfanuddinahmad merged commit 47ec64b into master Jan 19, 2024
5 of 6 checks passed
@irfanuddinahmad irfanuddinahmad deleted the iahmad/ENT-8192-2 branch January 19, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants