feat: skills quiz v2 enhancements #919
Conversation
mahamakifdar19
requested review from
adamstankiewicz,
saleem-latif,
irfanuddinahmad and
jajjibhai008
mahamakifdar19
force-pushed
the
maham/ENT-8191
branch
from
18899b6
to
8abea13
Compare
This comment was marked as outdated.
This comment was marked as outdated.
mahamakifdar19
force-pushed
the
maham/ENT-8191
branch
3 times, most recently
from
7e034d7
to
f9ca83e
Compare
mahamakifdar19
force-pushed
the
maham/ENT-8191
branch
from
f9ca83e
to
112aef2
Compare
| useEffect(() => { | ||
| const fetchLearnerCourseEnrollments = async () => { | ||
| try { | ||
| const response = await fetchCourseEnrollments(); |
There was a problem hiding this comment.
[curious/clarification] Is this fetchCourseEnrollments function returning all enrollments for the learner across all enterprises? Should we be referring to only the course enrollments relevant for the currently viewed enterprise customer, instead of all enrollments?
There was a problem hiding this comment.
@adamstankiewicz Yes, the fetchCourseEnrollments returns a list of all course enrollments for a user.
In Skills Quiz V1, we utilized this function to fetch the list of all enrollments and for consistency, I replicated the same approach in V2 as well.
There was a problem hiding this comment.
@mahamakifdar19 While this isn't blocking feedback, I still might recommend verifying with the team / Product whether this should be using all course enrollments vs. just the course enrollments associated with the specific enterprise customer. The Enterprise Learner Portal generally isn't supposed to be aware of B2C enrollments.
Jira Ticket: https://2u-internal.atlassian.net/browse/ENT-8191
Description: Added skills quiz v2 enhancements mentioned in the ticket and fixes for the style regressions caused in the application highlighted by @adamstankiewicz here
For all changes
Only if submitting a visual change