Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable TOP_DOWN_ASSIGNMENT feature #885

Closed
wants to merge 1 commit into from

Conversation

jajjibhai008
Copy link
Contributor

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 106 lines in your changes are missing coverage. Please review.

Comparison is base (d36b78a) 84.87% compared to head (d09e8dc) 85.10%.
Report is 91 commits behind head on master.

Files Patch % Lines
...ntent/course-enrollments/CourseAssignmentAlert.jsx 27.27% 8 Missing ⚠️
src/components/course/data/hooks.jsx 87.93% 7 Missing ⚠️
...course-enrollments/course-cards/BaseCourseCard.jsx 89.85% 7 Missing ⚠️
src/components/my-career/VisualizeCareer.jsx 74.07% 6 Missing and 1 partial ⚠️
src/components/my-career/data/service.js 56.25% 7 Missing ⚠️
src/components/course/data/utils.jsx 95.89% 6 Missing ⚠️
...n-content/course-enrollments/CourseEnrollments.jsx 81.25% 6 Missing ⚠️
src/components/my-career/AddJobRole.jsx 60.00% 5 Missing and 1 partial ⚠️
src/components/my-career/data/hooks.jsx 50.00% 6 Missing ⚠️
...oard/main-content/course-enrollments/data/utils.js 81.48% 5 Missing ⚠️
... and 24 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #885      +/-   ##
==========================================
+ Coverage   84.87%   85.10%   +0.23%     
==========================================
  Files         320      334      +14     
  Lines        6399     6969     +570     
  Branches     1552     1709     +157     
==========================================
+ Hits         5431     5931     +500     
- Misses        941     1007      +66     
- Partials       27       31       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamstankiewicz
Copy link
Member

As discussed in Slack, closing this PR in favor of enabling the feature flag via edx-internal (so it's specific to 2U/edX, not everyone who clones this repository);

@adamstankiewicz adamstankiewicz deleted the eahmadjaved/ENT-7669-5 branch December 7, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants