Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ENT-7851 Added course section title for learners's first visit #876

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

irfanuddinahmad
Copy link
Contributor

@irfanuddinahmad irfanuddinahmad commented Nov 28, 2023

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 98 lines in your changes are missing coverage. Please review.

Comparison is base (d36b78a) 84.87% compared to head (d0c6cc7) 84.34%.
Report is 125 commits behind head on master.

❗ Current head d0c6cc7 differs from pull request most recent head b72df26. Consider uploading reports for the commit b72df26 to get more accurate results

Files Patch % Lines
src/components/my-career/data/hooks.jsx 0.00% 12 Missing ⚠️
src/components/my-career/VisualizeCareer.jsx 74.07% 6 Missing and 1 partial ⚠️
src/components/my-career/data/service.js 56.25% 7 Missing ⚠️
src/components/course/data/utils.jsx 95.89% 6 Missing ⚠️
src/components/my-career/AddJobRole.jsx 71.42% 5 Missing and 1 partial ⚠️
src/components/app/App.jsx 0.00% 5 Missing ⚠️
src/components/app/EnterpriseAppPageRoutes.jsx 0.00% 5 Missing ⚠️
...components/enterprise-user-subsidy/data/service.js 0.00% 5 Missing ⚠️
src/components/academies/data/hooks.js 86.20% 4 Missing ⚠️
src/components/course/data/hooks.jsx 94.02% 4 Missing ⚠️
... and 22 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #876      +/-   ##
==========================================
- Coverage   84.87%   84.34%   -0.53%     
==========================================
  Files         320      343      +23     
  Lines        6399     7271     +872     
  Branches     1552     1782     +230     
==========================================
+ Hits         5431     6133     +702     
- Misses        941     1104     +163     
- Partials       27       34       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@irfanuddinahmad irfanuddinahmad force-pushed the iahmad/ENT-7851 branch 4 times, most recently from 3d3b5ff to 48a24d5 Compare December 6, 2023 11:10
@irfanuddinahmad irfanuddinahmad force-pushed the iahmad/ENT-7851 branch 4 times, most recently from d0c6cc7 to 43c315f Compare January 15, 2024 14:19
@irfanuddinahmad irfanuddinahmad merged commit 0cd16cf into master Jan 15, 2024
4 checks passed
@irfanuddinahmad irfanuddinahmad deleted the iahmad/ENT-7851 branch January 15, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants