Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide backdoors for search course #871

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Conversation

jajjibhai008
Copy link
Contributor

Description
When a learner

  • Is assigned a course,
  • And has no other subsidy, If they had a subscription, but the license is no longer relevant, we would not want to count that.

we disabled the course search for them.

There are “backdoors” that I have covered in this PR –

  • Course recommendations on the course page.
  • My Career Chart recommendations.
  • Someone sending a link to another learner of the course page.

JIRA -> ENT-7854

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 80 lines in your changes are missing coverage. Please review.

Comparison is base (d36b78a) 84.87% compared to head (66caa38) 85.14%.
Report is 79 commits behind head on master.

Files Patch % Lines
src/components/course/data/hooks.jsx 87.93% 7 Missing ⚠️
src/components/my-career/VisualizeCareer.jsx 74.07% 6 Missing and 1 partial ⚠️
src/components/my-career/data/service.js 56.25% 7 Missing ⚠️
src/components/course/data/utils.jsx 95.89% 6 Missing ⚠️
src/components/my-career/AddJobRole.jsx 60.00% 5 Missing and 1 partial ⚠️
src/components/my-career/data/hooks.jsx 50.00% 6 Missing ⚠️
...components/enterprise-user-subsidy/data/service.js 0.00% 5 Missing ⚠️
...n-content/course-enrollments/CourseEnrollments.jsx 82.60% 4 Missing ⚠️
src/components/my-career/SearchJobRole.jsx 91.48% 4 Missing ⚠️
...ourse-header/data/hooks/useCourseRunCardAction.jsx 50.00% 3 Missing ⚠️
... and 18 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #871      +/-   ##
==========================================
+ Coverage   84.87%   85.14%   +0.27%     
==========================================
  Files         320      325       +5     
  Lines        6399     6814     +415     
  Branches     1552     1662     +110     
==========================================
+ Hits         5431     5802     +371     
- Misses        941      981      +40     
- Partials       27       31       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jajjibhai008 jajjibhai008 merged commit 9dec77f into master Nov 22, 2023
6 checks passed
@jajjibhai008 jajjibhai008 deleted the eahmadjaved/ENT-7854 branch November 22, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants