chore: Update to the new version of brand-openedx in the new scope. #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Remaking this PR since it got removed along with some other changes last week. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #862 +/- ##
==========================================
+ Coverage 84.87% 85.13% +0.26%
==========================================
Files 320 325 +5
Lines 6399 6728 +329
Branches 1552 1633 +81
==========================================
+ Hits 5431 5728 +297
- Misses 941 969 +28
- Partials 27 31 +4
☔ View full report in Codecov by Sentry. |
brian-smith-tcril
approved these changes
Oct 31, 2023
adamstankiewicz
approved these changes
Oct 31, 2023
package.json
Outdated
| @@ -7,7 +7,7 @@ | |||
| "extends @edx/browserslist-config" | |||
| ], | |||
| "dependencies": { | |||
| "@edx/brand": "npm:@edx/brand-openedx@1.2.0", | |||
| "@edx/brand": "npm:@openedx/brand-openedx@^1.2.2", | |||
There was a problem hiding this comment.
nit: We generally pin dependencies in package.json (without the ^).
Part of openedx/axim-engineering#23 This updates the `@edx/brand` alias to point to the `brand-openedx` package at the `openedx` scope. This does not impact imports because this package is used via an alias.
feanil
force-pushed
the
feanil/update_brand_dependency
branch
from
6116701
to
de276d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of openedx/axim-engineering#23
This updates the
@edx/brandalias to point to thebrand-openedxpackage atthe
openedxscope. This does not impact imports because this package is usedvia an alias.