-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update to the new version of brand-openedx in the new scope. #862
Conversation
Remaking this PR since it got removed along with some other changes last week. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #862 +/- ##
==========================================
+ Coverage 84.87% 85.13% +0.26%
==========================================
Files 320 325 +5
Lines 6399 6728 +329
Branches 1552 1633 +81
==========================================
+ Hits 5431 5728 +297
- Misses 941 969 +28
- Partials 27 31 +4
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with 1 minor nit about pinning the version (convention).
package.json
Outdated
@@ -7,7 +7,7 @@ | |||
"extends @edx/browserslist-config" | |||
], | |||
"dependencies": { | |||
"@edx/brand": "npm:@edx/brand-openedx@1.2.0", | |||
"@edx/brand": "npm:@openedx/brand-openedx@^1.2.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: We generally pin dependencies in package.json
(without the ^
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, I'll update.
Part of openedx/axim-engineering#23 This updates the `@edx/brand` alias to point to the `brand-openedx` package at the `openedx` scope. This does not impact imports because this package is used via an alias.
6116701
to
de276d1
Compare
Part of openedx/axim-engineering#23
This updates the
@edx/brand
alias to point to thebrand-openedx
package atthe
openedx
scope. This does not impact imports because this package is usedvia an alias.