Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENT-7234: Filter jobs based on job source attribute. #786

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

saleem-latif
Copy link
Contributor

@saleem-latif saleem-latif commented Jul 13, 2023

Jira Ticket: ENT-7234

Job in Algolia either originate from course skills data or industry skills data. We want to ignore jobs that originate from industry skills data. This PR takes care of that.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 85.76% and project coverage change: +0.05% 🎉

Comparison is base (d36b78a) 84.87% compared to head (cfde6b0) 84.93%.
Report is 34 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #786      +/-   ##
==========================================
+ Coverage   84.87%   84.93%   +0.05%     
==========================================
  Files         320      323       +3     
  Lines        6399     6649     +250     
  Branches     1552     1619      +67     
==========================================
+ Hits         5431     5647     +216     
- Misses        941      971      +30     
- Partials       27       31       +4     
Files Changed Coverage Δ
.../components/course/course-header/CourseRunCard.jsx 100.00% <ø> (ø)
...ourse-header/data/hooks/useCourseRunCardAction.jsx 100.00% <ø> (ø)
...e/course-header/data/hooks/useCourseRunCardData.js 100.00% <ø> (ø)
src/components/course/data/constants.js 100.00% <ø> (ø)
src/components/course/data/service.js 46.51% <ø> (ø)
...rse/enrollment/components/ToDataSharingConsent.jsx 100.00% <ø> (ø)
.../course/enrollment/components/ToEcomBasketPage.jsx 75.00% <ø> (-1.93%) ⬇️
...nt/components/ToExecutiveEducation2UEnrollment.jsx 50.00% <0.00%> (ø)
src/components/course/enrollment/constants.js 100.00% <ø> (ø)
...xecutive-education-2u/ExecutiveEducation2UPage.jsx 100.00% <ø> (ø)
... and 35 more

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saleem-latif saleem-latif changed the title WIP -- ENT-7234: Filter jobs based on job source attribute. ENT-7234: Filter jobs based on job source attribute. Aug 4, 2023
Job in algolia either originate from course skills data or industry skills data. We want to ignore jobs that ignore from industry skills data at some places on the UI. This PR takes care of that.
Copy link
Contributor

@jajjibhai008 jajjibhai008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jajjibhai008 jajjibhai008 removed the request for review from bilaltahir21 August 7, 2023 07:07
@saleem-latif saleem-latif merged commit 8d8e46b into master Aug 7, 2023
5 checks passed
@saleem-latif saleem-latif deleted the saleem-latif/ENT-7234 branch August 7, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants