Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert "feat: Add additional messaging for no subsidy scenarios" #784

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

johnnagro
Copy link
Contributor

@johnnagro johnnagro commented Jul 5, 2023

Description

Next Steps

  • Marlon will likely revert the revert and track down the bug

@kiram15 kiram15 self-requested a review July 5, 2023 20:40
Copy link
Contributor

@kiram15 kiram15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Maybe put a comment in on the plans to un-revert it?

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 86.36% and project coverage change: -0.01 ⚠️

Comparison is base (d36b78a) 84.87% compared to head (206f24c) 84.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #784      +/-   ##
==========================================
- Coverage   84.87%   84.86%   -0.01%     
==========================================
  Files         320      322       +2     
  Lines        6399     6561     +162     
  Branches     1552     1595      +43     
==========================================
+ Hits         5431     5568     +137     
- Misses        941      964      +23     
- Partials       27       29       +2     
Impacted Files Coverage Δ
.../components/course/course-header/CourseRunCard.jsx 100.00% <ø> (ø)
...ourse-header/data/hooks/useCourseRunCardAction.jsx 100.00% <ø> (ø)
...e/course-header/data/hooks/useCourseRunCardData.js 100.00% <ø> (ø)
src/components/course/data/service.js 46.51% <ø> (ø)
...rse/enrollment/components/ToDataSharingConsent.jsx 100.00% <ø> (ø)
.../course/enrollment/components/ToEcomBasketPage.jsx 75.00% <ø> (-1.93%) ⬇️
...nt/components/ToExecutiveEducation2UEnrollment.jsx 50.00% <0.00%> (ø)
src/components/course/enrollment/constants.js 100.00% <ø> (ø)
...xecutive-education-2u/ExecutiveEducation2UPage.jsx 100.00% <ø> (ø)
...n-2u/components/EnrollmentCompletedSummaryCard.jsx 100.00% <ø> (ø)
... and 31 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@johnnagro johnnagro merged commit 0bfb8a7 into master Jul 5, 2023
@johnnagro johnnagro deleted the revert-771-mkeating/ENT-7223/0 branch July 5, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants