Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: front-end changes required for EE courses on LP #783

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

jajjibhai008
Copy link
Contributor

@jajjibhai008 jajjibhai008 commented Jul 3, 2023

Description
This PR covers following front-end changes for exec-ed courses on LP
No extraneous button present (email settings/unenroll if EE cannot be modified through LP)

  • No extraneous button present (email settings for EE)
  • Resume course button brings the learner to GetSmarter Dashboard
  • Button is grayed out and presents the course start date if the course has not started
  • Relevant course information is presented on the enrollment tile (start date).
  • Microcopy ex. ‘This course is self-led. Complete at your own speed before May 26, 2025.’ is updated dynamic with course end-date and EE pacing type.
  • for “Unenroll”, route learners to this link: https://www.getsmarter.com/cancel-defer
  • update the 3-dot menu and the footer text to light 300
  • change “instructor-paced” to “instructor-led”
  • change both the subtitle color (with partner name, etc) and footer color with “instructor-led” phrasing with end-date to text on dark: light 300

JIRA-> ENT-7166

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage: 85.71% and no project coverage change.

Comparison is base (d36b78a) 84.87% compared to head (0476d08) 84.87%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master     #783    +/-   ##
========================================
  Coverage   84.87%   84.87%            
========================================
  Files         320      322     +2     
  Lines        6399     6587   +188     
  Branches     1552     1603    +51     
========================================
+ Hits         5431     5591   +160     
- Misses        941      967    +26     
- Partials       27       29     +2     
Impacted Files Coverage Δ
.../components/course/course-header/CourseRunCard.jsx 100.00% <ø> (ø)
...ourse-header/data/hooks/useCourseRunCardAction.jsx 100.00% <ø> (ø)
...e/course-header/data/hooks/useCourseRunCardData.js 100.00% <ø> (ø)
src/components/course/data/service.js 46.51% <ø> (ø)
...rse/enrollment/components/ToDataSharingConsent.jsx 100.00% <ø> (ø)
.../course/enrollment/components/ToEcomBasketPage.jsx 75.00% <ø> (-1.93%) ⬇️
...nt/components/ToExecutiveEducation2UEnrollment.jsx 50.00% <0.00%> (ø)
src/components/course/enrollment/constants.js 100.00% <ø> (ø)
...e-enrollments/course-cards/CompletedCourseCard.jsx 87.50% <ø> (ø)
...e-enrollments/course-cards/RequestedCourseCard.jsx 100.00% <ø> (ø)
... and 38 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-7166 branch 2 times, most recently from 8eef650 to 87f6350 Compare July 4, 2023 14:49
@jajjibhai008 jajjibhai008 marked this pull request as ready for review July 5, 2023 07:06
@jajjibhai008 jajjibhai008 changed the title [WIP]feat: front-end changes required for EE courses on LP feat: front-end changes required for EE courses on LP Jul 5, 2023
@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-7166 branch 3 times, most recently from 1680ba4 to 588f3a3 Compare July 11, 2023 10:03
Copy link
Contributor

@bilaltahir21 bilaltahir21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-7166 branch 4 times, most recently from 503d4d6 to e336c13 Compare July 17, 2023 06:56
@jajjibhai008 jajjibhai008 merged commit 9a2fc99 into master Jul 17, 2023
5 checks passed
@jajjibhai008 jajjibhai008 deleted the eahmadjaved/ENT-7166 branch July 17, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants