-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: front-end changes required for EE courses on LP #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jajjibhai008
force-pushed
the
eahmadjaved/ENT-7166
branch
from
July 3, 2023 13:37
d7d16a0
to
d5c13b3
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #783 +/- ##
========================================
Coverage 84.87% 84.87%
========================================
Files 320 322 +2
Lines 6399 6587 +188
Branches 1552 1603 +51
========================================
+ Hits 5431 5591 +160
- Misses 941 967 +26
- Partials 27 29 +2
☔ View full report in Codecov by Sentry. |
jajjibhai008
force-pushed
the
eahmadjaved/ENT-7166
branch
2 times, most recently
from
July 4, 2023 14:49
8eef650
to
87f6350
Compare
jajjibhai008
changed the title
[WIP]feat: front-end changes required for EE courses on LP
feat: front-end changes required for EE courses on LP
Jul 5, 2023
saleem-latif
approved these changes
Jul 5, 2023
src/components/dashboard/main-content/course-enrollments/course-cards/BaseCourseCard.jsx
Outdated
Show resolved
Hide resolved
jajjibhai008
force-pushed
the
eahmadjaved/ENT-7166
branch
3 times, most recently
from
July 11, 2023 10:03
1680ba4
to
588f3a3
Compare
bilaltahir21
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
jajjibhai008
force-pushed
the
eahmadjaved/ENT-7166
branch
4 times, most recently
from
July 17, 2023 06:56
503d4d6
to
e336c13
Compare
jajjibhai008
force-pushed
the
eahmadjaved/ENT-7166
branch
from
July 17, 2023 07:02
e336c13
to
0476d08
Compare
adamstankiewicz
pushed a commit
that referenced
this pull request
Jul 19, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR covers following front-end changes for exec-ed courses on LP
No extraneous button present (email settings/unenroll if EE cannot be modified through LP)
JIRA-> ENT-7166
For all changes
Only if submitting a visual change