fix: check length on empty array for list price

[brobro10000]

Update check on returned list price length to correctly go into the fallback check for price.

For all changes

• Ensure adequate tests are in place (or reviewed existing tests cover changes)
• Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

• Ensure to attach screenshots
• Ensure to have UX team confirm screenshots

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (b3c1e56) to head (f34670a).
Report is 5 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1211   +/-   ##
=======================================
  Coverage   88.41%   88.41%           
=======================================
  Files         399      399           
  Lines        8501     8501           
  Branches     2088     2094    +6     
=======================================
  Hits         7516     7516           
+ Misses        943      942    -1     
- Partials       42       43    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pwnage101]

Is this missing a sub-key under the data top-level key? When we call useCourseMetdata, it doesn't normally just plop down the price as a value to the data key, does it?

[brobro10000]

In this case it does because of how useCourseListPrice utilizes the select within the useCourseMetadata arguments. It passes in the data from the transformed useCourseMetadata return value to resolve within getCoursePrice or the listPrice (acting as a no-op on the original course metadata)

export function useCourseListPrice() {
  const { data: { listPrice } } = useCourseRedemptionEligibility();
  const resolveListPrice = ({ transformed }) => listPrice || getCoursePrice(transformed);
  return useCourseMetadata({
    select: resolveListPrice,
  });
}