Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update course about sidebar to take into account usd fixed price #1199

Merged
merged 8 commits into from
Oct 8, 2024

chore: PR feedback 2

5fb9002
Select commit
Loading
Failed to load commit list.
Merged

feat: update course about sidebar to take into account usd fixed price #1199

chore: PR feedback 2
5fb9002
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 8, 2024 in 0s

88.41% (-0.02%) compared to f7bcbfe, passed because coverage increased by 0.01% when compared to adjusted base (88.39%)

View this Pull Request on Codecov

88.41% (-0.02%) compared to f7bcbfe, passed because coverage increased by 0.01% when compared to adjusted base (88.39%)

Details

Codecov Report

Attention: Patch coverage is 90.19608% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.41%. Comparing base (f7bcbfe) to head (5fb9002).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...s/app/data/hooks/useCourseRedemptionEligibility.js 80.00% 2 Missing ⚠️
src/components/course/data/utils.jsx 87.50% 2 Missing ⚠️
src/utils/common.js 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1199      +/-   ##
==========================================
- Coverage   88.42%   88.41%   -0.02%     
==========================================
  Files         396      399       +3     
  Lines        8407     8500      +93     
  Branches     2059     2093      +34     
==========================================
+ Hits         7434     7515      +81     
- Misses        930      942      +12     
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.