Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added Beta banner and Beta badge for videos #1169

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

jajjibhai008
Copy link
Contributor

@jajjibhai008 jajjibhai008 commented Aug 29, 2024

Description
• Implement "Beta" Badge with Tooltip next to "Video" heading
image

• Add Beta Announcement Banner to Search Page
image

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.36%. Comparing base (334d87c) to head (64d3b7a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1169      +/-   ##
==========================================
+ Coverage   88.21%   88.36%   +0.14%     
==========================================
  Files         394      396       +2     
  Lines        8392     8404      +12     
  Branches     2021     2062      +41     
==========================================
+ Hits         7403     7426      +23     
+ Misses        947      935      -12     
- Partials       42       43       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-9377-9378 branch 5 times, most recently from 7544e17 to 76178c4 Compare September 4, 2024 14:27
@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-9377-9378 branch 2 times, most recently from dd7ea3d to 6163409 Compare September 6, 2024 11:45
Copy link
Contributor

@mahamakifdar19 mahamakifdar19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from some minor nitpicks, LGTM

src/components/search/utils.js Outdated Show resolved Hide resolved
src/components/search/SearchResults.jsx Outdated Show resolved Hide resolved
@jajjibhai008 jajjibhai008 merged commit 913c976 into master Sep 9, 2024
6 checks passed
@jajjibhai008 jajjibhai008 deleted the eahmadjaved/ENT-9377-9378 branch September 9, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants