Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds end timestamp to maintenance banner #1165

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

brobro10000
Copy link
Member

@brobro10000 brobro10000 commented Aug 21, 2024

Adds MAINTENANCE_ALERT_END_TIMESTAMP as a way to preset an end timestamp for the maintenance banner.

Fields have been added to internal

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.07%. Comparing base (94a1676) to head (9517655).
Report is 2 commits behind head on master.

Files Patch % Lines
src/components/app/data/utils.js 75.00% 2 Missing ⚠️
src/index.jsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1165      +/-   ##
==========================================
- Coverage   88.09%   88.07%   -0.03%     
==========================================
  Files         394      394              
  Lines        8360     8371      +11     
  Branches     2053     2062       +9     
==========================================
+ Hits         7365     7373       +8     
- Misses        952      955       +3     
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brobro10000 brobro10000 merged commit 2c25cb4 into master Aug 22, 2024
5 of 7 checks passed
@brobro10000 brobro10000 deleted the hu/ent-maintenanacebanner-end-date branch August 22, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants