Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENT-9343] Fix autoplay setting for YouTube videos on course previews #1148

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

mahamakifdar19
Copy link
Contributor

@mahamakifdar19 mahamakifdar19 commented Aug 13, 2024

Ticket
https://2u-internal.atlassian.net/browse/ENT-9343

Description
Set autoplay to true for YouTube videos on the course about page (restoring previous behavior) and false for videos on the video detail page. This change resolves issues where video previews were breaking on the course about page.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.05%. Comparing base (8d4a976) to head (0bcfe90).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1148   +/-   ##
=======================================
  Coverage   88.05%   88.05%           
=======================================
  Files         393      393           
  Lines        8268     8268           
  Branches     1984     2026   +42     
=======================================
  Hits         7280     7280           
+ Misses        946      945    -1     
- Partials       42       43    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahamakifdar19 mahamakifdar19 force-pushed the maham/ENT-9343 branch 2 times, most recently from b89588c to 0e105bd Compare August 13, 2024 10:25
@mahamakifdar19 mahamakifdar19 changed the title [ENT-9343] Added a check to activate transcripts only when showTranscripts is enabled [ENT-9343] Fix autoplay setting for YouTube videos on course previews Aug 13, 2024
@mahamakifdar19 mahamakifdar19 merged commit b989dcb into master Aug 13, 2024
7 checks passed
@mahamakifdar19 mahamakifdar19 deleted the maham/ENT-9343 branch August 13, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants