fix: removes duplicate redirect

[brobro10000]

Updates redirect logic for routes /:slug/:courseType/course/:courseKey/enroll to not pass a onCheckoutSuccess function, and depend on the existing onSuccessfulRedemption logic in the useEffect to avoid duplicate redirects.

Also refactors the path name generation using generatePath instead of pushing (appending) to the end of a url.

For all changes

• Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

• Ensure to attach screenshots
• Ensure to have UX team confirm screenshots

[adamstankiewicz]

LGTM with a tiny nit, and when CI is passing (currently pending) :)

[codecov]

Codecov Report

Attention: 143 lines in your changes are missing coverage. Please review.

Comparison is base (d36b78a) 84.87% compared to head (d9f05ac) 84.96%.
Report is 106 commits behind head on master.

Files	Patch %	Lines
src/components/search/Search.jsx	0.00%	29 Missing ⚠️
...ntent/course-enrollments/CourseAssignmentAlert.jsx	27.27%	8 Missing ⚠️
src/components/course/data/hooks.jsx	88.70%	7 Missing ⚠️
...course-enrollments/course-cards/BaseCourseCard.jsx	89.85%	7 Missing ⚠️
src/components/my-career/VisualizeCareer.jsx	74.07%	6 Missing and 1 partial ⚠️
src/components/my-career/data/service.js	56.25%	7 Missing ⚠️
src/components/course/data/utils.jsx	95.89%	6 Missing ⚠️
src/components/my-career/AddJobRole.jsx	60.00%	5 Missing and 1 partial ⚠️
src/components/my-career/data/hooks.jsx	50.00%	6 Missing ⚠️
...rc/components/search/AssignmentsOnlyEmptyState.jsx	0.00%	6 Missing ⚠️
... and 28 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #904      +/-   ##
==========================================
+ Coverage   84.87%   84.96%   +0.08%     
==========================================
  Files         320      338      +18     
  Lines        6399     7088     +689     
  Branches     1552     1733     +181     
==========================================
+ Hits         5431     6022     +591     
- Misses        941     1035      +94     
- Partials       27       31       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.