chore: PR fixes

openedx · Dec 14, 2023 · da89e3f · da89e3f
1 parent 3ceaecc
commit da89e3f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/src/components/course/routes/ExternalCourseEnrollment.jsx b/src/components/course/routes/ExternalCourseEnrollment.jsx
@@ -66,13 +66,12 @@ const ExternalCourseEnrollment = () => {
       containerRef.current.scrollIntoView({ behavior: 'smooth' });
     }
   }, [externalCourseFormSubmissionError, containerRef]);
-
   useEffect(() => {
     // Once a redemption has successfully completed and the can-redeem query has been invalidated or
     // a user attempts to navigate directly to :slug/executive-education-2u/course/:courseKey/enroll,
     //  it will run this conditional and perform the redirect
     if (hasSuccessfulRedemption) {
-      history.push({ pathname: completeEnrollmentUrl });
+      history.push(completeEnrollmentUrl);
     }
   }, [completeEnrollmentUrl, course.key, hasSuccessfulRedemption, history, routeMatch.path, slug]);
 

diff --git a/src/components/course/routes/tests/ExternalCourseEnrollment.test.jsx b/src/components/course/routes/tests/ExternalCourseEnrollment.test.jsx
@@ -120,13 +120,9 @@ describe('ExternalCourseEnrollment', () => {
     expect(screen.getByTestId('user-enrollment-form')).toBeInTheDocument();
     expect(UserEnrollmentForm.mock.calls[0][0]).toEqual(
       expect.objectContaining({
-        onCheckoutSuccess: expect.any(Function),
         productSKU: 'test-sku',
       }),
     );
-    UserEnrollmentForm.mock.calls[0][0].onCheckoutSuccess();
-    expect(mockHistoryPush).toHaveBeenCalledTimes(1);
-    expect(mockHistoryPush).toHaveBeenCalledWith('enroll/complete');
   });
 
   it.each([