Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed info Optimizely logs #177

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

JodyBaileyy
Copy link
Contributor

@JodyBaileyy JodyBaileyy commented Jul 13, 2023

Description

  • Adjusted the creation of the Optimizely client to set the log level to error before creating the client, so only logs with a level of error are output to the console.

This is because currently, all Optimizely logs are being output to the console, and 1 log in particular includes the currently logged in user's ID, which poses as a potential security issue

JIRA Ticket

PTECH-3307

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (103a676) 96.29% compared to head (e959305) 96.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #177   +/-   ##
=======================================
  Coverage   96.29%   96.29%           
=======================================
  Files         182      182           
  Lines        1699     1702    +3     
  Branches      300      300           
=======================================
+ Hits         1636     1639    +3     
  Misses         58       58           
  Partials        5        5           
Impacted Files Coverage Δ
src/widgets/ProductRecommendations/optimizely.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@JodyBaileyy JodyBaileyy merged commit ed23682 into master Jul 17, 2023
5 checks passed
@JodyBaileyy JodyBaileyy deleted the jodybaileyy/remove-optimizely-logs branch July 17, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants