Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow runtime configuration (#253) #282

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

ghassanmas
Copy link
Member

Allows frontend-app-gradebook to be configured at
runtime using the LMS's new MFE Configuration API.

Part of openedx/wg-frontend#103

TL;DR - [ A short summary of what this PR does and why ]

JIRA: JIRA-XXXX

What changed?

  • [ More in depth breakdown of changes ]
  • [ Peripheral things that got changed ]
  • [ etc... ]

Developer Checklist

  • Test suites passing
  • Documentation and test plan updated, if applicable
  • Received code-owner approving review
  • Bumped version number package.json

Testing Instructions

[ How should a reviewer test this PR? ]

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

Allows frontend-app-gradebook to be configured at
runtime using the LMS's new MFE Configuration API.

Part of openedx/wg-frontend#103
@ghassanmas ghassanmas requested a review from a team as a code owner November 12, 2022 09:56
@openedx-webhooks
Copy link

Thanks for the pull request, @ghassanmas! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 12, 2022
@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (d2723e5) compared to base (03fa143).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           open-release/olive.master      #282   +/-   ##
===========================================================
  Coverage                     100.00%   100.00%           
===========================================================
  Files                            108       110    +2     
  Lines                           1260      1264    +4     
  Branches                         248       248           
===========================================================
+ Hits                            1260      1264    +4     
Impacted Files Coverage Δ
src/App.jsx 100.00% <ø> (ø)
src/head/Head.jsx 100.00% <100.00%> (ø)
src/head/messages.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a clean cherry-pick from master. +1

@arbrandes arbrandes merged commit bccd87f into openedx:open-release/olive.master Nov 14, 2022
@openedx-webhooks
Copy link

@ghassanmas 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants