Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added package-lock file version check #236

Merged
merged 1 commit into from
May 25, 2022
Merged

Conversation

Jawayria
Copy link
Contributor

@Jawayria Jawayria commented May 9, 2022

lockfileVersion for the package-lock.json generated by NPM6 was 1 but now as we've moved to Node16 and NPM8, package-lock.json should be generated using NPM8. lockfileVersion for package-lock.json generated using NPM8 is 2. So here we're going to check the lockfileVersion in package-lock.json

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #236 (b6f2659) into main (474aaac) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #236   +/-   ##
=======================================
  Coverage   82.47%   82.47%           
=======================================
  Files          37       37           
  Lines         582      582           
  Branches      185      185           
=======================================
  Hits          480      480           
  Misses         99       99           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 474aaac...b6f2659. Read the comment docs.

@Jawayria Jawayria merged commit c7d5eca into main May 25, 2022
@Jawayria Jawayria deleted the jawayria/pkg-lock-check branch May 25, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants