Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restricted unnecessary api calls #683

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Conversation

sundasnoreen12
Copy link
Contributor

INF-1295

Description

Need following Improvements for the "Content Unavailable" Screen in the Discussion MFE and In-Context Sidebar.

A.C

  1. Optimized API calls by restricted unnecessary parallel requests, only invoking the API returning the isEnroll attribute when needed, and prevented additional calls.
  2. Ensured that unavailable content within the in-context sidebar remains hidden across all use cases.

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.83%. Comparing base (4914f51) to head (ccd3b96).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #683   +/-   ##
=======================================
  Coverage   92.82%   92.83%           
=======================================
  Files         158      158           
  Lines        3304     3307    +3     
  Branches      896      899    +3     
=======================================
+ Hits         3067     3070    +3     
  Misses        218      218           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/discussions/data/selectors.js Outdated Show resolved Hide resolved
@sundasnoreen12 sundasnoreen12 merged commit 7db4fde into master Apr 4, 2024
7 checks passed
@sundasnoreen12 sundasnoreen12 deleted the sundas/INF-1295 branch April 4, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants