Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: null error at useRouteMatch when running on tutor #613

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix: null error at useRouteMatch when running on tutor #613

merged 1 commit into from
Dec 6, 2023

Commits on Dec 6, 2023

  1. fix: null error at useRouteMatch when running on tutor 

    tutor sets the PUBLIC_PATH to '/discussions' which causes frontend-platform to
treat all URLs for matching etc to be relative to this path. Since many places
include '/discussions' in the match it causes those matches to break.

This change makes the default PUBLIC_PATH in .env.development to match the one
set by tutor and removes it from the base path of the router letting frontend
platform handle the prefix.

This also allows for deployments to customise this path to be something other
than 'discussions'.
    @xitij2000
    xitij2000 committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    3b2d831 View commit details
    Browse the repository at this point in the history