Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with a repeated search query #540

Merged

Conversation

DmytroAlipov
Copy link
Contributor

Description

An issue has been found with research if no changes are made to the search field:

  • first search:
    image-1

  • second search:
    image-2

This fix allows actions to be ignored if the current search query matches a previous query.
If there are any changes in the search query, then it is sent to the backend.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 19, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@DmytroAlipov DmytroAlipov changed the title fix: issue with a repeated search query Fix bug with a repeated search query Jun 19, 2023
@itsjeyd
Copy link

itsjeyd commented Jun 20, 2023

Hey @DmytroAlipov, thank you for this contribution! It looks like the changes are ready for review?

@awais-ansari
Copy link
Contributor

@DmytroAlipov Thank you for this contribution! The Team will review this PR Shortly.

@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Jul 5, 2023
@DmytroAlipov
Copy link
Contributor Author

@awais-ansari just a friendly ping, all tests passed ;)

@awais-ansari awais-ansari removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Jul 12, 2023
@DmytroAlipov
Copy link
Contributor Author

I updated brunch.

@edx-requirements-bot edx-requirements-bot merged commit 445caca into openedx:master Jul 13, 2023
3 checks passed
@openedx-webhooks
Copy link

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@DmytroAlipov DmytroAlipov deleted the fix-discussion-search branch July 13, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants