feat: update react & react-dom to v17 #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #537 +/- ##
=======================================
Coverage 92.30% 92.30%
=======================================
Files 170 170
Lines 3468 3468
Branches 904 904
=======================================
Hits 3201 3201
Misses 246 246
Partials 21 21 ☔ View full report in Codecov by Sentry. |
awais-ansari
requested changes
Jul 12, 2023
There was a problem hiding this comment.
@Mashal-m Please upgrade all package versions to a specific one. No need to add ^.
@awais-ansari Upgraded! |
awais-ansari
approved these changes
Jul 12, 2023
asadazam93
approved these changes
Jul 12, 2023
snglth
pushed a commit
to Abstract-Tech/community-theme-discussions
that referenced
this pull request
Jan 9, 2024
* feat: update react & react-dom to v17 * build: update pkgs * fix: fix test * build: remove ^ from pkgs --------- Co-authored-by: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Upgrade React JS to v17
Description
react&react-domto v17, along with@testing-library/reactto respective compatible versionsparagonto fix react-loading-skeleton issue@edx/frontend-platform, @edx/frontend-component-header, @edx/frontend-component-footerHow Has This Been Tested?
Please describe in detail how you tested your changes.
Screenshots/sandbox (optional):
Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.
Merge Checklist
Post-merge Checklist