Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FC-0014][olive] update frontend-platform version to v4.2.0 #504

Conversation

UvgenGen
Copy link
Contributor

@UvgenGen UvgenGen commented Apr 25, 2023

Description

Updated frontend-platform version with GA4 implementation.
FC-0014 - Google Analytics 4 Upgrade

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks
Copy link

Thanks for the pull request, @UvgenGen! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 25, 2023
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Apr 25, 2023
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7dfbd44) 85.06% compared to head (3c62df8) 85.06%.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           open-release/olive.master     #504   +/-   ##
==========================================================
  Coverage                      85.06%   85.06%           
==========================================================
  Files                            134      134           
  Lines                           2678     2678           
  Branches                         741      741           
==========================================================
  Hits                            2278     2278           
  Misses                           378      378           
  Partials                          22       22           
Impacted Files Coverage Δ
src/discussions/posts/PostsList.jsx 97.29% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Apr 26, 2023
@bmtcril bmtcril changed the title [FC-0014][palm] update frontend-platform version to v4.2.0 [FC-0014][olive] update frontend-platform version to v4.2.0 May 9, 2023
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works alright. Congrats.

@arbrandes arbrandes merged commit 0f7921a into openedx:open-release/olive.master May 9, 2023
@openedx-webhooks
Copy link

@UvgenGen 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants