-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hardcoded course mode checkboxes #191
fix: hardcoded course mode checkboxes #191
Conversation
Thanks for the pull request, @dyudyunov! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #191 +/- ##
==========================================
+ Coverage 83.01% 83.23% +0.22%
==========================================
Files 46 47 +1
Lines 683 692 +9
Branches 132 135 +3
==========================================
+ Hits 567 576 +9
Misses 116 116 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks @dyudyunov!
@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
The Communication MFE has course mode checkboxes hardcoded, so a user can select any of them even if the course has no such mode.
As a result - they will get an error when trying to send emails to learners of the track (course mode) that doesn't exist.
The goal here is to provide course mode checkboxes for real course modes only.