Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing ENABLE_NEW_EDITOR_PAGES flag #951

Merged
merged 3 commits into from
Apr 25, 2024
Merged

fix: removing ENABLE_NEW_EDITOR_PAGES flag #951

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4672720
fix: comparing values to actual bool instead of string
felipemontoya Apr 11, 2024
3d3c55d
fix: removing checks as per PR discussion
felipemontoya Apr 24, 2024
1e32166
chore: cleanup after removing the checks
felipemontoya Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/CourseAuthoringRoutes.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,11 @@
))}
<Route
path="editor/course-videos/:blockId"
element={getConfig().ENABLE_NEW_EDITOR_PAGES === 'true' ? <PageWrap><VideoSelectorContainer courseId={courseId} /></PageWrap> : null}
element={getConfig().ENABLE_NEW_EDITOR_PAGES === true ? <PageWrap><VideoSelectorContainer courseId={courseId} /></PageWrap> : null}

Check failure on line 85 in src/CourseAuthoringRoutes.jsx

View workflow job for this annotation

GitHub Actions / tests 

This line has a length of 141. Maximum allowed is 120
/>
<Route
path="editor/:blockType/:blockId?"
element={getConfig().ENABLE_NEW_EDITOR_PAGES === 'true' ? <PageWrap><EditorContainer courseId={courseId} /></PageWrap> : null}
element={getConfig().ENABLE_NEW_EDITOR_PAGES === true ? <PageWrap><EditorContainer courseId={courseId} /></PageWrap> : null}

Check failure on line 89 in src/CourseAuthoringRoutes.jsx

View workflow job for this annotation

GitHub Actions / tests 

This line has a length of 134. Maximum allowed is 120
/>
<Route
path="settings/details"
Expand Down
Loading