Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont allow course detail page to break editor #790

Merged

Conversation

connorhaugh
Copy link
Contributor

At the moment, editors served from V1 libraries are broken because they use the course authoring MFE url (because they use editors in the same way courses do).

This was introduced here: #761

This fix fixes that.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0debaec) 89.69% compared to head (dc2b304) 89.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #790   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files         503      503           
  Lines        8193     8193           
  Branches     1721     1721           
=======================================
  Hits         7349     7349           
  Misses        817      817           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@connorhaugh connorhaugh merged commit a3975f4 into master Jan 11, 2024
6 checks passed
@connorhaugh connorhaugh deleted the fix--allow-for-course-detail-page-not-found-for-editors- branch January 11, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants