-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: active transcript preference not loading #682
fix: active transcript preference not loading #682
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #682 +/- ##
==========================================
+ Coverage 87.97% 88.32% +0.34%
==========================================
Files 415 420 +5
Lines 6396 6526 +130
Branches 1379 1408 +29
==========================================
+ Hits 5627 5764 +137
+ Misses 745 737 -8
- Partials 24 25 +1 ☔ View full report in Codecov by Sentry. |
@@ -3,6 +3,7 @@ import { | |||
act, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this file, I can't see a test case which matches the issue described in the ticket. Could you add a
"Now the correct option is selected when the settings are loaded" Test? That would improve my confidence in what this PR is trying to do.
userEvent.click(orderButton); | ||
}); | ||
|
||
it('should load page with Cielo24 selected', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet thanks!
JIRA Ticket: TNL-11199
This PR corrects the loading of the active transcript preferences. Previously the selected transcript option was given the full object of preferences instead of the provider so none of the options were selected on load. Now the correct option is selected when the settings are loaded.
Testing (locally)
*Will need to be fully tested in stage environment where the video pipeline is fully enabled
TranscriptSettings.jsx
)with