feat: remove old/duplicate proctoring component #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharis278
force-pushed
the
zhancock/remove-old-proctoring-ui
branch
2 times, most recently
from
4e0c92b to
cd48bce
Compare
zacharis278
force-pushed
the
zhancock/remove-old-proctoring-ui
branch
from
cd48bce to
75fabb7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #671 +/- ##
==========================================
- Coverage 88.19% 87.98% -0.22%
==========================================
Files 417 414 -3
Lines 6598 6398 -200
Branches 1428 1382 -46
==========================================
- Hits 5819 5629 -190
+ Misses 755 745 -10
Partials 24 24
☔ View full report in Codecov by Sentry. |
alangsto
approved these changes
Nov 9, 2023
| @@ -61,7 +62,7 @@ const CourseAuthoringRoutes = () => { | |||
| /> | |||
| <Route | |||
| path="proctored-exam-settings" | |||
| element={<PageWrap><ProctoredExamSettings courseId={courseId} /></PageWrap>} | |||
| element={<Navigate replace to={`/course/${courseId}/pages-and-resources`} />} | |||
Ian2012
pushed a commit
to eduNEXT/frontend-app-course-authoring
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no reason to maintain a second copy of this component anymore. The pages and resources UI has been released for years without issue. Let's remove this old page. I've left the old pages route with a redirect to pages and resources as a nicety for anyone who had the old page bookmarked.
PR to remove links to the old page from the LMS: openedx/edx-platform#33679
2U JIRA: COSMO-59