Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to the new version of brand-openedx in the new scope. #646

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Oct 19, 2023

Part of openedx/axim-engineering#23

This updates the @edx/brand alias to point to the brand-openedx package at
the openedx scope. This does not impact imports because this package is used
via an alias.

Part of openedx/axim-engineering#23

This updates the `@edx/brand` alias to point to the `brand-openedx` package at
the `openedx` scope. This does not impact imports because this package is used
via an alias.
@feanil feanil requested a review from a team October 19, 2023 19:54
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6705f63) 86.06% compared to head (1592ca3) 86.06%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #646   +/-   ##
=======================================
  Coverage   86.06%   86.06%           
=======================================
  Files         383      383           
  Lines        5757     5757           
  Branches     1268     1268           
=======================================
  Hits         4955     4955           
  Misses        777      777           
  Partials       25       25           
Files Coverage Δ
src/files-and-uploads/messages.js 100.00% <ø> (ø)
src/header/messages.js 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brian-smith-tcril brian-smith-tcril merged commit 9715429 into master Oct 20, 2023
6 checks passed
@brian-smith-tcril brian-smith-tcril deleted the feanil/update_brand_dependency branch October 20, 2023 17:29
rpenido pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Oct 24, 2023
…penedx#646)

Part of openedx/axim-engineering#23

This updates the `@edx/brand` alias to point to the `brand-openedx` package at
the `openedx` scope. This does not impact imports because this package is used
via an alias.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants