Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable invalid link Video Uploads #513

Conversation

DmytroAlipov
Copy link
Contributor

This is the backport of the master.

Description

This PR is opened to solve the problem with an invalid link to the Video Uploads page. This question has already been asked here.
I suggest adding the variable ENABLE_VIDEO_UPLOAD_PAGE_LINK_IN_CONTENT_DROPDOWN to the .env file in order to control the visibility of this link. Since currently, the link above is not functional, I recommend setting it to False by default.

Before:

ENABLE_VIDEO_UPLOADS

After:

DISABLE_VIDEO_UPLOADS

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 7, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.64 🎉

Comparison is base (a94942a) 74.53% compared to head (af203db) 75.17%.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           open-release/palm.master     #513      +/-   ##
============================================================
+ Coverage                     74.53%   75.17%   +0.64%     
============================================================
  Files                           108      108              
  Lines                          2089     2091       +2     
  Branches                        514      516       +2     
============================================================
+ Hits                           1557     1572      +15     
+ Misses                          504      491      -13     
  Partials                         28       28              
Impacted Files Coverage Δ
src/studio-header/Header.jsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jun 7, 2023
@mphilbrick211 mphilbrick211 requested a review from a team June 7, 2023 23:19
@jristau1984 jristau1984 merged commit bc3faa4 into openedx:open-release/palm.master Jun 8, 2023
@openedx-webhooks
Copy link

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@DmytroAlipov DmytroAlipov deleted the fix-disable-video-uploads-palm branch June 9, 2023 06:29
sambapete pushed a commit to EDUlib/frontend-app-course-authoring that referenced this pull request Oct 11, 2023
sambapete pushed a commit to EDUlib/frontend-app-course-authoring that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants