-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support arbitrary asset upload/deletion for Library Components [FC-0062] #1430
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @bradenmacdonald! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
9fe72c6
to
d010d55
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1430 +/- ##
==========================================
- Coverage 93.16% 93.16% -0.01%
==========================================
Files 1053 1054 +1
Lines 20410 20464 +54
Branches 4363 4356 -7
==========================================
+ Hits 19015 19065 +50
- Misses 1332 1339 +7
+ Partials 63 60 -3 ☔ View full report in Codecov by Sentry. |
@ormsbee @kdmccormick It's ready for you review |
const uploadData = new FormData(); | ||
const file = fileData.get('file') as File; | ||
uploadData.set('content', file); // Paragon calls this 'file' but our API needs it called 'content' | ||
// TODO: make the filename unique if is already exists in assets list, to avoid overwriting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think overwriting will be a common and desired use case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, maybe a future improvement would be just to show a confirmation dialog/warning in that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment updated ^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable to me. I have not tested it though, as I'm having unrelated issues with my dev environment.
@ormsbee You can test it on the sandbox. |
oh... right... 😄 Thank you! |
So I think this is actually working, but the server endpoint is not setting is_learner_downloadbale properly. I'll make a PR to fix that. |
Description
Implements #1400
Testing instructions
Details
tabAdvanced details