Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no validation for combined length of org, course number and course run for Redwood #1261

Conversation

DmytroAlipov
Copy link
Contributor

@DmytroAlipov DmytroAlipov commented Sep 6, 2024

This is a backport from the master.

Description

There's no validation for combined length of organization, course number and course run:

111

For legacy:

222

Fix:

12345

@DmytroAlipov DmytroAlipov requested a review from a team as a code owner September 6, 2024 08:28
@openedx-webhooks
Copy link

Thanks for the pull request, @DmytroAlipov!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (open-release/redwood.master@8518933). Learn more about missing BASE report.

Additional details and impacted files
@@                      Coverage Diff                       @@
##             open-release/redwood.master    #1261   +/-   ##
==============================================================
  Coverage                               ?   92.32%           
==============================================================
  Files                                  ?      708           
  Lines                                  ?    12553           
  Branches                               ?     2695           
==============================================================
  Hits                                   ?    11590           
  Misses                                 ?      926           
  Partials                               ?       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmytroAlipov DmytroAlipov force-pushed the fix-validation-for-combined-length-redwood branch 7 times, most recently from 4ffcf7d to c0615cf Compare September 6, 2024 12:08
@DmytroAlipov
Copy link
Contributor Author

@pomegranited @KristinAoki Hi! Could you please pay attention to this PR? I would like this fix to be included in the Redwood.3 release since this validation seems necessary. They completely forgot about it when they transferred logic to MFE.

@DmytroAlipov
Copy link
Contributor Author

I'm already working on a fix for the master.

@DmytroAlipov DmytroAlipov changed the title fix: no validation for combined length of org, course number and course run fix: no validation for combined length of org, course number and course run for Redwood Sep 6, 2024
@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Sep 6, 2024
@DmytroAlipov DmytroAlipov force-pushed the fix-validation-for-combined-length-redwood branch from c0615cf to adbe888 Compare September 9, 2024 16:34
@DmytroAlipov DmytroAlipov force-pushed the fix-validation-for-combined-length-redwood branch from adbe888 to 4ef2b86 Compare September 9, 2024 16:58
@pomegranited
Copy link
Contributor

Hi @DmytroAlipov , thank you for submitting this fix. I'd love to help but I'm not a CC on this repo, so FYI @openedx/2u-tnl @mphilbrick211

@KristinAoki KristinAoki merged commit 4556562 into openedx:open-release/redwood.master Sep 10, 2024
6 checks passed
@DmytroAlipov DmytroAlipov deleted the fix-validation-for-combined-length-redwood branch September 10, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants