-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: no validation for combined length of org, course number and course run for Redwood #1261
fix: no validation for combined length of org, course number and course run for Redwood #1261
Conversation
Thanks for the pull request, @DmytroAlipov! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/redwood.master #1261 +/- ##
==============================================================
Coverage ? 92.32%
==============================================================
Files ? 708
Lines ? 12553
Branches ? 2695
==============================================================
Hits ? 11590
Misses ? 926
Partials ? 37 ☔ View full report in Codecov by Sentry. |
4ffcf7d
to
c0615cf
Compare
@pomegranited @KristinAoki Hi! Could you please pay attention to this PR? I would like this fix to be included in the Redwood.3 release since this validation seems necessary. They completely forgot about it when they transferred logic to MFE. |
I'm already working on a fix for the master. |
c0615cf
to
adbe888
Compare
adbe888
to
4ef2b86
Compare
Hi @DmytroAlipov , thank you for submitting this fix. I'd love to help but I'm not a CC on this repo, so FYI @openedx/2u-tnl @mphilbrick211 |
4556562
into
openedx:open-release/redwood.master
This is a backport from the master.
Description
There's no validation for combined length of organization, course number and course run:
For legacy:
Fix: