Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only show course blocks in the search modal #1148

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Jul 10, 2024

Description

This PR limits the scope of the search in the modal to only course blocks.

Testing instructions

  • Using master go to the search modal and make sure you have any library XBlock indexed.
  • Check out this branch, go to the search modal again, and the libraries blocks should be filtered out.

@rpenido rpenido requested a review from a team as a code owner July 10, 2024 10:07
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 10, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@rpenido rpenido force-pushed the rpenido/fal-3753-limit-modal-search-to-course-content branch from 7a9e561 to a784637 Compare July 10, 2024 10:18
@rpenido rpenido force-pushed the rpenido/fal-3753-limit-modal-search-to-course-content branch from a784637 to 7136ad1 Compare July 10, 2024 10:19
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.68%. Comparing base (09822c2) to head (7136ad1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1148   +/-   ##
=======================================
  Coverage   92.68%   92.68%           
=======================================
  Files         694      694           
  Lines       12359    12359           
  Branches     2701     2701           
=======================================
  Hits        11455    11455           
  Misses        873      873           
  Partials       31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I tested and it seems to be working well.

@bradenmacdonald bradenmacdonald merged commit 71fcf9f into openedx:master Jul 10, 2024
7 checks passed
@openedx-webhooks
Copy link

@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@bradenmacdonald bradenmacdonald deleted the rpenido/fal-3753-limit-modal-search-to-course-content branch July 10, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants