Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: add upload progress modal" #1128

Merged

Conversation

KristinAoki
Copy link
Member

Reverts #1113

The functionality of this PR is approved. However, it introduced new lint and test errors to master, as master was not merged into the feature branch before merge so the new lint rules were not run and tests were not re-ran.

@KristinAoki KristinAoki requested a review from a team as a code owner June 24, 2024 16:04
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.60%. Comparing base (6414196) to head (1605125).
Report is 1 commits behind head on master.

Files Patch % Lines
src/files-and-videos/videos-page/data/thunks.js 94.28% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1128   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files         710      710           
  Lines       12683    12683           
  Branches     2799     2799           
=======================================
  Hits        11745    11745           
  Misses        902      902           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KristinAoki KristinAoki merged commit 9317b87 into master Jun 24, 2024
6 checks passed
@KristinAoki KristinAoki deleted the revert-1113-KristinAoki/add-upload-progress-modal branch June 24, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants