Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Search result redirect to unit lib component #1027

Conversation

yusuf-musleh
Copy link
Member

@yusuf-musleh yusuf-musleh commented May 22, 2024

Description

This PR fixes redirection to the library component in the unit when selecting the search result. It also fixes an issue with navigating to the library mfe when selecting a library component.

Testing instructions

  1. Run this branch on your local tutor
  2. Make sure you have meilisearch configured and running in your local tutor
  3. Make sure you have a Content Library with some blocks created under it, eg: text or dropdown blocks
  4. Make sure you have a course that contains a library block in a Unit that includes a Content Library block from the previous step. You probably need to use the old studio UI to select the Content Library to be in the library component block in the Unit if you don't already have one set (since you cannot edit library components in the new mfe UI yet)
  5. Use the search modal in the mfe to search for the library block that belongs to the library component that is inside the Unit (make sure that you are clicking on the block that is inside the unit, not the actual library component that)
  6. Confirm that it will navigate to the correct unit context and highlight the library component in the unit (i.e. "Randomized Content Block")

Private-ref: FAL-3724

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 22, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented May 22, 2024

Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/fix-search-redirect-to-lib-components branch from 66c9505 to 4f11445 Compare May 23, 2024 12:03
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.40%. Comparing base (7247cc2) to head (cf7e750).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1027   +/-   ##
=======================================
  Coverage   92.40%   92.40%           
=======================================
  Files         708      708           
  Lines       12523    12529    +6     
  Branches     2702     2706    +4     
=======================================
+ Hits        11572    11578    +6     
  Misses        914      914           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/fix-search-redirect-to-lib-components branch 2 times, most recently from 080747e to 1d8bf9d Compare May 23, 2024 13:20
@yusuf-musleh yusuf-musleh marked this pull request as ready for review May 23, 2024 13:31
@yusuf-musleh yusuf-musleh requested a review from a team as a code owner May 23, 2024 13:31
@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/fix-search-redirect-to-lib-components branch from 1d8bf9d to cf7e750 Compare May 23, 2024 13:33
Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yusuf-musleh Looks good! 👍

  • I tested this: I followed the testing instructions
  • I read through the code and considered the security, stability and performance implications of the changes.
  • I tested that the UI can be used with a keyboard only (tab order, keyboard controls).
  • Includes tests for bugfixes and/or features added.
  • Includes documentation

@yusuf-musleh yusuf-musleh requested a review from xitij2000 May 24, 2024 07:13
@yusuf-musleh
Copy link
Member Author

@xitij2000 Friendly reminder if you can take a look at this today.

@xitij2000 xitij2000 merged commit 8cde43e into openedx:master Jun 3, 2024
6 checks passed
@openedx-webhooks
Copy link

@yusuf-musleh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@xitij2000 xitij2000 deleted the yusuf-musleh/fix-search-redirect-to-lib-components branch June 3, 2024 12:25
yusuf-musleh added a commit to open-craft/frontend-app-authoring that referenced this pull request Jun 4, 2024
This change fixes redirection to the library component in the unit when selecting the search result. It also fixes an issue with navigating to the library MFE when selecting a library component.
yusuf-musleh added a commit to open-craft/frontend-app-authoring that referenced this pull request Jun 5, 2024
This change fixes redirection to the library component in the unit when selecting the search result. It also fixes an issue with navigating to the library MFE when selecting a library component.
xitij2000 pushed a commit that referenced this pull request Jun 5, 2024
This change fixes redirection to the library component in the unit when selecting the search result. It also fixes an issue with navigating to the library MFE when selecting a library component.
bra-i-am pushed a commit to eduNEXT/frontend-app-course-authoring that referenced this pull request Aug 9, 2024
…nedx#1069)

This change fixes redirection to the library component in the unit when selecting the search result. It also fixes an issue with navigating to the library MFE when selecting a library component.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants