fix: change the totalRegisterationTime to snake case #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahtesham-quraish
force-pushed
the
ahtesham/VAN-1816
branch
2 times, most recently
from
5d87376
to
67585f9
Compare
src/register/data/utils.js
Outdated
Comment on lines
137
to
138
| payload = snakeCaseObject(payload); | ||
| payload.totalRegistrationTime = totalRegistrationTime; | ||
| payload.total_registration_time = totalRegistrationTime; |
There was a problem hiding this comment.
payload.totalRegistrationTime = totalRegistrationTime;
payload = snakeCaseObject(payload);
24ca3ea
to
16951d4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1301 +/- ##
=======================================
Coverage 87.69% 87.69%
=======================================
Files 124 124
Lines 2299 2299
Branches 642 645 +3
=======================================
Hits 2016 2016
Misses 274 274
Partials 9 9 ☔ View full report in Codecov by Sentry. |
abdullahwaheed
approved these changes
Aug 27, 2024
Description: Convert the totalRegistrationTime to snake case VAN-1816
ahtesham-quraish
force-pushed
the
ahtesham/VAN-1816
branch
from
16951d4
to
fad9fda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JIRA
VAN-1816
How Has This Been Tested?
Here is the backend PR fix: convert totalRegistrationTime to snake case edx-platform#35333