Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp: move restrictionType check prior to check for late redemption #1340

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

iloveagent57
Copy link
Contributor

Helps protect against a case where late redemption is enabled for a budget and a restricted course run's enroll-by date is within the 30 day late enrollment offset. Without this change, we'd potentially surface a restricted run to a customer without a restricted run allowed by any of the customer's catalogs.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.70%. Comparing base (e196e52) to head (3022022).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...components/learner-credit-management/data/utils.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1340      +/-   ##
==========================================
+ Coverage   85.69%   85.70%   +0.01%     
==========================================
  Files         591      591              
  Lines       12924    12924              
  Branches     2736     2734       -2     
==========================================
+ Hits        11075    11077       +2     
+ Misses       1788     1787       -1     
+ Partials       61       60       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iloveagent57 iloveagent57 merged commit 888fb6b into master Oct 22, 2024
5 of 6 checks passed
@iloveagent57 iloveagent57 deleted the aed/fix-restriction-check branch October 22, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants