feat: mark strings for i18n on lpr page #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhammad-ammar
force-pushed
the
ammar/mark-strings-for-i8n-on-lpr-page
branch
5 times, most recently
from
da29e53
to
30849db
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1221 +/- ##
==========================================
+ Coverage 85.34% 85.37% +0.03%
==========================================
Files 537 537
Lines 11632 11672 +40
Branches 2413 2464 +51
==========================================
+ Hits 9927 9965 +38
Misses 1656 1656
- Partials 49 51 +2 ☔ View full report in Codecov by Sentry. |
muhammad-ammar
force-pushed
the
ammar/mark-strings-for-i8n-on-lpr-page
branch
4 times, most recently
from
5367fa8
to
6f6176d
Compare
| if (actionSlug) { | ||
| downloadButtonLabel = intl.formatMessage({ | ||
| id: 'admin.portal.lpr.current.report.csv.download', | ||
| defaultMessage: 'Download current report (CSV)', |
There was a problem hiding this comment.
where we are handling Download full report (CSV) ?
There was a problem hiding this comment.
Download full report (CSV) is handled here
jajjibhai008
approved these changes
May 21, 2024
executed |
…l report section on lpr page
muhammad-ammar
force-pushed
the
ammar/mark-strings-for-i8n-on-lpr-page
branch
from
6f6176d
to
951ea91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all changes
Only if submitting a visual change