Skip to content

Commit

Permalink
Merge pull request #1270 from openedx/sameeramin/ENT-8806
Browse files Browse the repository at this point in the history
fix: port and password bug fixes in Reporting Configurations
  • Loading branch information
sameeramin authored Aug 1, 2024
2 parents 2dad691 + 6405116 commit 67f42b7
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions src/components/ReportingConfig/SFTPDeliveryMethodForm.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const SFTPDeliveryMethodForm = ({ invalidFields, config, handleBlur }) => {
<div className="row">
<div className="col">
<Form.Group
controlId="sftpHostname"
isInvalid={invalidFields.sftpHostname}
>
<Form.Label>
Expand All @@ -21,6 +22,7 @@ const SFTPDeliveryMethodForm = ({ invalidFields, config, handleBlur }) => {
/>
</Form.Label>
<Form.Control
name="sftpHostname"
defaultValue={config ? config.sftpHostname : undefined}
onBlur={e => handleBlur(e)}
data-hj-suppress
Expand All @@ -39,6 +41,7 @@ const SFTPDeliveryMethodForm = ({ invalidFields, config, handleBlur }) => {
</div>
<div className="col col-2">
<Form.Group
controlId="sftpPort"
isInvalid={invalidFields.sftpPort}
>
<Form.Label>
Expand All @@ -49,7 +52,8 @@ const SFTPDeliveryMethodForm = ({ invalidFields, config, handleBlur }) => {
/>
</Form.Label>
<Form.Control
as="number"
type="number"
name="sftpPort"
defaultValue={config ? config.sftpPort : 22}
onBlur={e => handleBlur(e)}
/>
Expand All @@ -75,6 +79,7 @@ const SFTPDeliveryMethodForm = ({ invalidFields, config, handleBlur }) => {
<div className="row">
<div className="col">
<Form.Group
controlId="sftpUsername"
isInvalid={invalidFields.sftpUsername}
>
<Form.Label>
Expand All @@ -85,6 +90,7 @@ const SFTPDeliveryMethodForm = ({ invalidFields, config, handleBlur }) => {
/>
</Form.Label>
<Form.Control
name="sftpUsername"
defaultValue={config ? config.sftpUsername : undefined}
onBlur={e => handleBlur(e)}
data-hj-suppress
Expand Down Expand Up @@ -123,11 +129,13 @@ const SFTPDeliveryMethodForm = ({ invalidFields, config, handleBlur }) => {
</Form.Group>
)}
<Form.Group
controlId="encryptedSftpPassword"
isInvalid={invalidFields.encryptedSftpPassword}
>
<Form.Label>SFTP Password</Form.Label>
<Form.Control
as="password"
name="encryptedSftpPassword"
type="password"
onBlur={e => handleBlur(e)}
disabled={config && !checked}
data-hj-suppress
Expand All @@ -150,6 +158,7 @@ const SFTPDeliveryMethodForm = ({ invalidFields, config, handleBlur }) => {
)}
</Form.Group>
<Form.Group
controlId="sftpFilePath"
isInvalid={invalidFields.sftpFilePath}
>
<Form.Label>
Expand All @@ -160,6 +169,7 @@ const SFTPDeliveryMethodForm = ({ invalidFields, config, handleBlur }) => {
/>
</Form.Label>
<Form.Control
name="sftpFilePath"
defaultValue={config ? config.sftpFilePath : undefined}
onBlur={e => handleBlur(e)}
data-hj-suppress
Expand Down

0 comments on commit 67f42b7

Please sign in to comment.