Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add signal back as optional param #163

Merged
merged 2 commits into from
May 11, 2023
Merged

fix: add signal back as optional param #163

merged 2 commits into from
May 11, 2023

Conversation

rgraber
Copy link
Contributor

@rgraber rgraber commented May 11, 2023 •
edited
Loading

Re-add the 'signal' parameter to the KafkaEventConsumer, as is expected by the EventBusConsumer API.

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed
  • Noted any: Concerns, dependencies, deadlines, tickets, testing instructions

@rgraber rgraber marked this pull request as ready for review May 11, 2023 15:43
@rgraber rgraber merged commit a89a2fb into main May 11, 2023
@rgraber rgraber deleted the rsgraber/20230511-add-signal-back branch May 11, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robrap robrap robrap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgraber @robrap